Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timeInputV2 #4635

Merged
merged 5 commits into from
Jan 16, 2025
Merged

feat: timeInputV2 #4635

merged 5 commits into from
Jan 16, 2025

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Jan 2, 2025

Summary

Type

  • Feature

Summarise concisely:

What is expected?

New component <TimeInputV2 />

@lisalupi lisalupi self-assigned this Jan 2, 2025
@lisalupi lisalupi requested a review from matthprost as a code owner January 2, 2025 14:36
Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: f9381db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/form Patch
@ultraviolet/ui Minor
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 99.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.09%. Comparing base (2205ef6) to head (f9381db).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/TimeInputV2/index.tsx 98.59% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4635      +/-   ##
==========================================
+ Coverage   87.43%   88.09%   +0.65%     
==========================================
  Files         335      348      +13     
  Lines       12722    13361     +639     
  Branches     3471     3638     +167     
==========================================
+ Hits        11124    11770     +646     
+ Misses       1598     1591       -7     
Files with missing lines Coverage Δ
...mponents/TimeInputFieldV2/__tests__/index.test.tsx 100.00% <100.00%> (ø)
...ges/form/src/components/TimeInputFieldV2/index.tsx 100.00% <100.00%> (ø)
...rc/components/TimeInputV2/__tests__/helper.test.ts 100.00% <100.00%> (ø)
...rc/components/TimeInputV2/__tests__/index.test.tsx 100.00% <100.00%> (ø)
...ackages/ui/src/components/TimeInputV2/constants.ts 100.00% <100.00%> (ø)
packages/ui/src/components/TimeInputV2/helpers.ts 100.00% <100.00%> (ø)
packages/ui/src/components/TimeInputV2/index.tsx 98.59% <98.59%> (ø)

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40bd38...f9381db. Read the comment docs.

.changeset/funny-gifts-shave.md Show resolved Hide resolved
packages/ui/src/components/index.ts Show resolved Hide resolved
packages/ui/src/components/index.ts Show resolved Hide resolved
packages/ui/src/components/TimeInputV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/TimeInputV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/TimeInputV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/TimeInputV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/TimeInputV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/TimeInputV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/TimeInputV2/index.tsx Outdated Show resolved Hide resolved
@lisalupi lisalupi requested review from johnrazeur and a team as code owners January 9, 2025 09:07
packages/ui/src/components/TimeInputV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/TimeInputV2/index.tsx Outdated Show resolved Hide resolved
@lisalupi lisalupi merged commit b4b5366 into main Jan 16, 2025
14 checks passed
@lisalupi lisalupi deleted the feat/time-input branch January 16, 2025 14:01
@scaleway-bot scaleway-bot mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants